Refactor: no internal pipe method use #7321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes internal usage of the `pipe` method, so that in the future, other observables that do not implement `pipe` will work with our operators
benlesh
force-pushed
the
refactor-no-internal-pipe-method
branch
from
3ee2c7a
to
36fe017
Compare
|
Under current Core team agreement, I'm merging this without additional review, as it's been up a long time and is landing in an alpha version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes internal usage of the
pipemethod, so that in the future, other observables that do not implementpipewill work with our operators.This PR doesn't have the explicit goal of ensuring operators work with "observable shaped things", but it's a step in that direction.